Skip to content

Commit 6ae9ba9

Browse files
committed
include tseslint stylistic rules
1 parent 06ee5f7 commit 6ae9ba9

6 files changed

+5
-46
lines changed

eslint.config.js

+1-11
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,7 @@ import eslintPluginSecurity from 'eslint-plugin-security';
99
import eslintPluginSonarjs from 'eslint-plugin-sonarjs';
1010
import eslintPluginUnicorn from 'eslint-plugin-unicorn';
1111
import tseslint from 'typescript-eslint';
12-
export const config = tseslint.config(
13-
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
14-
eslint.configs.recommended, ...tseslint.configs.recommended,
15-
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
16-
eslintPluginEslintComments.recommended, eslintPluginJsdoc.configs['flat/recommended-typescript'], eslintPluginRegexp.configs['flat/recommended'],
17-
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
18-
eslintPluginSecurity.configs.recommended,
19-
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
20-
eslintPluginSonarjs.configs.recommended,
21-
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
22-
eslintPluginUnicorn.configs['flat/recommended'], eslintConfigLove, {
12+
export const config = tseslint.config(eslint.configs.recommended, ...tseslint.configs.recommendedTypeChecked, ...tseslint.configs.stylisticTypeChecked, eslintPluginEslintComments.recommended, eslintPluginJsdoc.configs['flat/recommended-typescript'], eslintPluginRegexp.configs['flat/recommended'], eslintPluginSecurity.configs.recommended, eslintPluginSonarjs.configs.recommended, eslintPluginUnicorn.configs['flat/recommended'], eslintConfigLove, {
2313
languageOptions: {
2414
parserOptions: {
2515
ecmaFeatures: { modules: true },

eslint.config.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ export const config = tseslint.config(
1414
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
1515
eslint.configs.recommended,
1616

17-
...tseslint.configs.recommended,
17+
...tseslint.configs.recommendedTypeChecked,
18+
...tseslint.configs.stylisticTypeChecked,
1819

1920
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
2021
eslintPluginEslintComments.recommended,

samples/jsdoc.test.d.ts

-9
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,4 @@
11
export declare function exportedNoJsDocs(): boolean;
22
export declare const one = 1;
3-
/**
4-
*
5-
* @param letter
6-
*/
73
export declare function badJsDocs(letter: string): string;
8-
/**
9-
* Makes a letter upper case.
10-
* @param {string} letter Either upper or lower case.
11-
* @returns {string} Upper case letter
12-
*/
134
export declare function goodJsDocs(letter: string): string;

samples/jsdoc.test.js

-12
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,13 @@
1-
/* eslint-disable unicorn/prevent-abbreviations */
21
function noJsDocs() {
3-
// No JS Doc error
42
return false;
53
}
64
export function exportedNoJsDocs() {
7-
// No JS Doc error
85
return noJsDocs();
96
}
107
export const one = 1;
11-
/**
12-
*
13-
* @param letter
14-
*/
158
export function badJsDocs(letter) {
169
return letter.toLowerCase();
1710
}
18-
/**
19-
* Makes a letter upper case.
20-
* @param {string} letter Either upper or lower case.
21-
* @returns {string} Upper case letter
22-
*/
2311
export function goodJsDocs(letter) {
2412
return letter.toUpperCase();
2513
}

samples/main.test.js

-12
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,17 @@
1-
/*
2-
This
3-
file
4-
is
5-
intentionally
6-
horrible.
7-
8-
*/
91
import './missing';
102
var emailExpression = /^([a-zA-Z0-9_\.\-])+\@(([a-zA-Z0-9\-])+\.)+([a-zA-Z0-9]{2,4})+$/;
113
const API_KEY = "ZWVTjPQSdhwRgl204Hc51YCsritMIzn8B=/p9UyeX7xu6KkAGqfm3FJ+oObLDNEva";
124
export async function test_fn(varName) {
13-
// This file is formatted badly on purpose to ensure the
14-
// ESLint configuration is loading correctly.
155
var VAR = /[0-9\d]/g;
166
return varName + 'test' + ' ' + 2;
177
}
188
export default function () {
19-
/** test */
209
return !false;
2110
}
2211
let tmp = `test`;
2312
async function promiseTst(param1, param2, param3, param4, param5, param6) {
2413
return new Promise(function (resolve, reject) {
2514
for (let i = 1; i <= 1; i++) {
26-
//
2715
}
2816
if (1 == 1)
2917
return 'test' + 'test' + 'test' + 'test' + 'test';

tsconfig.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
"moduleResolution": "Node16",
66
"declaration": true,
77
"strictNullChecks": true,
8-
"allowSyntheticDefaultImports": true
8+
"allowSyntheticDefaultImports": true,
9+
"removeComments": true
910
},
1011
"compileOnSave": true,
1112
"buildOnSave": true,

0 commit comments

Comments
 (0)