From 184c4d1348f6a7c863e969124dff1936d1408ad6 Mon Sep 17 00:00:00 2001 From: gabcoyne Date: Thu, 22 Oct 2020 10:07:46 -0500 Subject: [PATCH 1/5] Add list comprehension string typing for connection --- knackpy/formatters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/knackpy/formatters.py b/knackpy/formatters.py index 3ee3635..e834574 100644 --- a/knackpy/formatters.py +++ b/knackpy/formatters.py @@ -113,4 +113,4 @@ def connection(value): # expecting a list of dicts like so: # [{'id': '5e7b63a0c279e606c645be7d', 'identifier': 'Some String'}] identifiers = [conn["identifier"] for conn in value] - return ", ".join(identifiers) + return ", ".join(str(v) for v in identifiers) From 2b950cac08acfca9dd8d8f40e493fc8f60477772 Mon Sep 17 00:00:00 2001 From: John Clary Date: Wed, 18 Nov 2020 16:13:14 -0600 Subject: [PATCH 2/5] convert conn identifiers to strings when handling --- knackpy/formatters.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/knackpy/formatters.py b/knackpy/formatters.py index 3ee3635..e10674d 100644 --- a/knackpy/formatters.py +++ b/knackpy/formatters.py @@ -111,6 +111,6 @@ def connection(value): return None else: # expecting a list of dicts like so: - # [{'id': '5e7b63a0c279e606c645be7d', 'identifier': 'Some String'}] - identifiers = [conn["identifier"] for conn in value] + # [{'id': '5e7b63a0c279e606c645be7d', 'identifier': 'Some Val'}] + identifiers = [str(conn["identifier"]) for conn in value] return ", ".join(identifiers) From 95eff5d78688210f851da6f781692de5893e796d Mon Sep 17 00:00:00 2001 From: John Clary Date: Wed, 18 Nov 2020 16:13:50 -0600 Subject: [PATCH 3/5] bump version --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index fbc5e3b..7e11102 100644 --- a/setup.py +++ b/setup.py @@ -46,7 +46,7 @@ def build_config(env, readme="README.md"): "packages": ["knackpy"], "tests_require": ["pytest", "coverage"], "url": "http://github.com/cityofaustin/knackpy", - "version": "1.0.13", + "version": "1.0.14", } From ba975ed701c5e964e4009be0da517d78ed47bc51 Mon Sep 17 00:00:00 2001 From: John Clary Date: Wed, 18 Nov 2020 16:17:37 -0600 Subject: [PATCH 4/5] Revert "Convert connection identifiers to strings when formatting them" --- knackpy/formatters.py | 4 ++-- setup.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/knackpy/formatters.py b/knackpy/formatters.py index e10674d..3ee3635 100644 --- a/knackpy/formatters.py +++ b/knackpy/formatters.py @@ -111,6 +111,6 @@ def connection(value): return None else: # expecting a list of dicts like so: - # [{'id': '5e7b63a0c279e606c645be7d', 'identifier': 'Some Val'}] - identifiers = [str(conn["identifier"]) for conn in value] + # [{'id': '5e7b63a0c279e606c645be7d', 'identifier': 'Some String'}] + identifiers = [conn["identifier"] for conn in value] return ", ".join(identifiers) diff --git a/setup.py b/setup.py index 7e11102..fbc5e3b 100644 --- a/setup.py +++ b/setup.py @@ -46,7 +46,7 @@ def build_config(env, readme="README.md"): "packages": ["knackpy"], "tests_require": ["pytest", "coverage"], "url": "http://github.com/cityofaustin/knackpy", - "version": "1.0.14", + "version": "1.0.13", } From 0db777fbd244c015f12400a0e2e8b157f12cf57e Mon Sep 17 00:00:00 2001 From: John Clary Date: Wed, 18 Nov 2020 16:19:52 -0600 Subject: [PATCH 5/5] bump version --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index fbc5e3b..7e11102 100644 --- a/setup.py +++ b/setup.py @@ -46,7 +46,7 @@ def build_config(env, readme="README.md"): "packages": ["knackpy"], "tests_require": ["pytest", "coverage"], "url": "http://github.com/cityofaustin/knackpy", - "version": "1.0.13", + "version": "1.0.14", }