Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cgroup: align with upstream 6.11 CONFIG_MEMCG_V1 CONFIG_CPUSETS_V1 #3041

Closed
2 tasks done
tixxdz opened this issue Oct 24, 2024 · 2 comments
Closed
2 tasks done

Cgroup: align with upstream 6.11 CONFIG_MEMCG_V1 CONFIG_CPUSETS_V1 #3041

tixxdz opened this issue Oct 24, 2024 · 2 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@tixxdz
Copy link
Member

tixxdz commented Oct 24, 2024

What happened?

Tests on bpf-next are failing https://github.com/cilium/tetragon/actions/runs/11500178416/job/32010347721?pr=2615 due to memory controller being split, where v1 is now under its own:

Our cgroup logic works by trying to detect available controllers from /proc/cgroups and uses the memory then pids where they should always be available, however due this change memory v1 controller is not available there, so we switch to use pids, but I suspect that test is failing due to some race conditions as we run the test quickly, however in container load tests are passing which suggest the race.

Anyway since now the memory v1 logic was split, we have to check:

  • If memory v1 is not mounted, adapt the userspace detection logic and ensure that we continue to read cgroup names correctly so we work transparently with both cgroupv1 or cgroupv2
    • Added more checks to ensure that cgroupv1 is properly set, and ensured that cgroupv2 also works.
  • Fix the failing test and maybe cover new cases
    • We have tests to cover all cases, some already detected this change, and we added new ones.

Tetragon Version

head

Kernel Version

6.11

Kubernetes Version

No response

Bugtool

No response

Relevant log output

No response

Anything else?

No response

@tixxdz tixxdz added the kind/bug Something isn't working label Oct 24, 2024
@tixxdz tixxdz self-assigned this Oct 24, 2024
@tixxdz tixxdz changed the title Cgroup: align with upstream linux-next CONFIG_MEMCG_V1 Cgroup: align with upstream 6.11 CONFIG_MEMCG_V1 CONFIG_CPUSETS_V1 Oct 29, 2024
@tixxdz
Copy link
Member Author

tixxdz commented Oct 29, 2024

Fix is here: #3053

@tixxdz
Copy link
Member Author

tixxdz commented Nov 5, 2024

Merged fix and added more tests to ensure we handle new cgroupv1 configs

@tixxdz tixxdz closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant