Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag a 0.6.2 release #340

Closed
kolyshkin opened this issue Jul 8, 2021 · 4 comments
Closed

Tag a 0.6.2 release #340

kolyshkin opened this issue Jul 8, 2021 · 4 comments

Comments

@kolyshkin
Copy link
Contributor

PR #336 was recently merged to help with issue in runc, so runc now vendors the updated version (opencontainers/runc#3055).

The only concern is we're now vendoring by a sha, rather than using a tag.

Is it possible to tag a minor release (I guess v0.6.2) so that runc can use it? 🙏🏻

Cc // @lmb @ti-mo

@lmb
Copy link
Collaborator

lmb commented Jul 9, 2021

Timo came back from time off, so I want to give him some time to catch up before tagging a release.

Is there a downside to using a hash vs. a tag?

@ti-mo
Copy link
Collaborator

ti-mo commented Jul 9, 2021

No objections for tagging 0.6.2 here, hopefully the error propagation story is now in a good enough shape so this type of issue doesn't occur in the future anymore. 👍

@kolyshkin
Copy link
Contributor Author

Is there a downside to using a hash vs. a tag?

Not much really; a hash may not feel kosher, and a tag is perceived more like a commitment ("yes, this functionality is included in version x.y.z"). Surely we are OK with a hash, if having a release cut is problematic.

@ti-mo
Copy link
Collaborator

ti-mo commented Jul 12, 2021

We've released https://github.com/cilium/ebpf/releases/tag/v0.6.2 today, closing this.

@ti-mo ti-mo closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants