-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag a 0.6.2 release #340
Comments
Timo came back from time off, so I want to give him some time to catch up before tagging a release. Is there a downside to using a hash vs. a tag? |
No objections for tagging 0.6.2 here, hopefully the error propagation story is now in a good enough shape so this type of issue doesn't occur in the future anymore. 👍 |
Not much really; a hash may not feel kosher, and a tag is perceived more like a commitment ("yes, this functionality is included in version x.y.z"). Surely we are OK with a hash, if having a release cut is problematic. |
We've released https://github.com/cilium/ebpf/releases/tag/v0.6.2 today, closing this. |
PR #336 was recently merged to help with issue in runc, so runc now vendors the updated version (opencontainers/runc#3055).
The only concern is we're now vendoring by a sha, rather than using a tag.
Is it possible to tag a minor release (I guess v0.6.2) so that runc can use it? 🙏🏻
Cc // @lmb @ti-mo
The text was updated successfully, but these errors were encountered: