Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about non-supported flags in map specs #1072

Closed
aditighag opened this issue Jun 23, 2023 · 2 comments · Fixed by #1102
Closed

Warn about non-supported flags in map specs #1072

aditighag opened this issue Jun 23, 2023 · 2 comments · Fixed by #1102
Assignees
Labels
enhancement New feature or request

Comments

@aditighag
Copy link
Member

When an LRU map spec has the BPF_F_NO_PREALLOC flag, the library fails to load BPF programs with the error - map create: operation not supported (without BTF k/v). This is misleading, as the main issue here is that the kernel doesn't support these flags for LRU type maps.

The library could give hints about such not supported configurations while loading map specs.

It could be a candidate for good first issues, but I'll leave the judgement call to you. /cc @ti-mo

@aditighag aditighag added the enhancement New feature or request label Jun 23, 2023
@kwakubiney
Copy link
Member

kwakubiney commented Jul 6, 2023

Looks like something I'd like to pick up after I wrap this up since it's a similar problem

@kwakubiney
Copy link
Member

kwakubiney commented Jul 24, 2023

Same misleading error is seen when noPrealloc flag is used with maps of type BPF_MAP_TYPE_BLOOM_FILTER , BPF_MAP_TYPE_ARRAY , BPF_MAP_TYPE_ARRAY_OF_MAPS , BPF_MAP_TYPE_PERCPU_ARRAY and BPF_MAP_TYPE_RINGBUF. Doesn't look like the library supports BPF_MAP_TYPE_BLOOM_FILTER though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants