From 9b395e49bf8ca094785fc449a4279cc2ba9fc513 Mon Sep 17 00:00:00 2001 From: David Baker Date: Mon, 11 Dec 2017 23:22:57 -0700 Subject: [PATCH] Fixing small grammatical glitches --- text/0000-remove-application-wrapper.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/text/0000-remove-application-wrapper.md b/text/0000-remove-application-wrapper.md index 2fdbccea96..acead4f4c2 100644 --- a/text/0000-remove-application-wrapper.md +++ b/text/0000-remove-application-wrapper.md @@ -21,11 +21,11 @@ export default Ember.Application.extend({ ``` However, whatever the root is, the application adds another `
` wrapper -that it's not required anymore. It's just a vestigial reminder of some implementation +that it's not required anymore. It's just a vestigial remainder of some implementation detail of how views worked in Ember 1.x. Some sort of wisdom tooth of the original -rendering system that it serves no purpose today. +rendering system that serves no purpose today. -Furthermore, much like a wisdom tooth, it can gives us problems. In the past this element +Furthermore, much like a wisdom tooth, it can give us problems. In the past, this element was configurable using the `ApplicationView`, but when views were removed we lost that ability. Right now we are stuck with a wrapper element we can't remove and we also can't customize, which is why some apps target the selector `body > .ember-view` to style this @@ -47,7 +47,7 @@ container. ## API Surface The proposed approach is identical to the one proposed in #278, that I reproduce -pristine below in italic: +pristine below in italics: *We should not expose the flag directly as a public API. Instead, we should abstract the flag with a "privileged addon" whose only purpose is to enable @@ -78,7 +78,7 @@ any class or id they want. # How We Teach This This addon will be an opt in, but at some point it will become part of -the default blueprint. This change, rather than introducing a new concept, it *removes* +the default blueprint. This change, rather than introducing a new concept, *removes* an old one. Users won't have to google what is the way to remove or customize the implicit application wrapper of the app (to sadly discover that is not even possible), but instead they will just add a wrapper only if they want, @@ -96,4 +96,4 @@ html hierarchy for some reason, and those addons would have to be updated. # Alternatives -Leave things as they are today. \ No newline at end of file +Leave things as they are today.