Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSDOM custom element support conflicts with our shim #95

Closed
tmeasday opened this issue Feb 17, 2020 · 1 comment
Closed

JSDOM custom element support conflicts with our shim #95

tmeasday opened this issue Feb 17, 2020 · 1 comment
Assignees
@ndelangen
Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request

Comments

@tmeasday
Copy link
Member

tmeasday commented Feb 17, 2020 •
edited
Loading

Error:

Cannot read property '_customElementDefinitions' of undefined

Occurs when you use JSDOM 16.2 w/ latests storybook-chromatic.

I've fixed our depedency to 16.1.x for now, but we can probably drop our shim now.

To QA

Run a build with JSDOM > 16, check it works.
@tmeasday tmeasday added enhancement Classification: New feature or request customer reported Tracking: This issue was reported through customer support labels Feb 17, 2020
@ndelangen ndelangen mentioned this issue Mar 25, 2020
Merged
@tmeasday tmeasday self-assigned this Apr 9, 2020
@tmeasday
Copy link
Member Author

LGTM

@tmeasday tmeasday removed their assignment Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndelangen ndelangen

Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmeasday @ndelangen