Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with build-storybook being an alias to another script #79

Closed
tmeasday opened this issue Dec 18, 2019 · 3 comments
Closed

Deal with build-storybook being an alias to another script #79

tmeasday opened this issue Dec 18, 2019 · 3 comments
Assignees
Labels
bug Classification: Something isn't working customer reported Tracking: This issue was reported through customer support has workaround Tracking: This issue has an available workaround

Comments

@tmeasday
Copy link
Member

This fairly uncontroversial setup:

https://github.com/planningcenter/design/blob/2531a8ab7437b96581c310c3a8fee82fd1c7820e/package.json#L42-L43

Stuffs us up because the -o flag doesn't end up getting passed through to the build script.

Related to #78

@tmeasday tmeasday added bug Classification: Something isn't working customer reported Tracking: This issue was reported through customer support labels Dec 18, 2019
@ndelangen
Copy link
Member

I don't see a -o in the linked example?

@tmeasday
Copy link
Member Author

We add a -o $tmpdir flag and I guess the way npm/yarn works it didn't end up passing through to the final command.

@ndelangen
Copy link
Member

The user can use the --build-script-name to point the cli to the correct script OR they could use yarn (which does passes though any flags) OR they could use something like:

    "build": "build-storybook",
    "build-storybook": "npm run build --",

@ndelangen ndelangen added the has workaround Tracking: This issue has an available workaround label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working customer reported Tracking: This issue was reported through customer support has workaround Tracking: This issue has an available workaround
Projects
None yet
Development

No branches or pull requests

2 participants