Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories with parameters.chromatic.disable: true show "New story found" #294

Closed
ghengeveld opened this issue Apr 28, 2024 · 1 comment · Fixed by #300
Closed

Stories with parameters.chromatic.disable: true show "New story found" #294

ghengeveld opened this issue Apr 28, 2024 · 1 comment · Fixed by #300
Assignees
Labels
bug Classification: Something isn't working sev:S3

Comments

@ghengeveld
Copy link
Member

Describe the bug

Stories where Chromatic is explicitly disabled will always show the "New story found" screen. Running a build will not snapshot it and thus continue to show this screen. There should be an explanation that the current story is disabled for Chromatic.

To reproduce

Create a story like this:

export const ChromaticDisabled = {
  parameters: {
    chromatic: { disable: true }
  }
}

Open the Visual Tests panel on this story, it will show this screen:

Screenshot 2024-04-28 at 12 28 35

Run a build and confirm it continues to show this screen.

Environment

Storybook v8.0.9 for Next.js.
Visual Tests addon v1.3.3.

@shilman shilman added bug Classification: Something isn't working sev:S3 labels May 7, 2024
@shilman
Copy link
Member

shilman commented May 7, 2024

@ghengeveld Not critical but pretty annoying! We should fix during cooldown if possible.

@ghengeveld ghengeveld self-assigned this May 8, 2024
@ghengeveld ghengeveld linked a pull request May 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working sev:S3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants