diff --git a/.github/workflows/scorecards-analysis.yml b/.github/workflows/scorecards-analysis.yml index d163ac3e94c38..3302968b3ce77 100644 --- a/.github/workflows/scorecards-analysis.yml +++ b/.github/workflows/scorecards-analysis.yml @@ -41,7 +41,7 @@ jobs: # Upload the results as artifacts (optional). - name: "Upload artifact" - uses: actions/upload-artifact@6673cd052c4cd6fcf4b4e6e60ea986c889389535 + uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce with: name: SARIF file path: results.sarif diff --git a/packages/flutter_tools/lib/src/commands/update_packages.dart b/packages/flutter_tools/lib/src/commands/update_packages.dart index 4ac5b356bf0a3..8451a8c013e5f 100644 --- a/packages/flutter_tools/lib/src/commands/update_packages.dart +++ b/packages/flutter_tools/lib/src/commands/update_packages.dart @@ -384,7 +384,7 @@ class UpdatePackagesCommand extends FlutterCommand { fakePackage.writeAsStringSync( _generateFakePubspec( dependencies, - useAnyVersion: doUpgrade, + doUpgrade: doUpgrade, ), ); // Create a synthetic flutter SDK so that transitive flutter SDK @@ -1321,8 +1321,17 @@ class PubspecDependency extends PubspecLine { /// This generates the entry for this dependency for the pubspec.yaml for the /// fake package that we'll use to get the version numbers figured out. - void describeForFakePubspec(StringBuffer dependencies, StringBuffer overrides, { bool useAnyVersion = true}) { - final String versionToUse = useAnyVersion || version.isEmpty ? 'any' : version; + void describeForFakePubspec(StringBuffer dependencies, StringBuffer overrides, { bool doUpgrade = true }) { + final String versionToUse; + if (version.isEmpty) { + versionToUse = 'any'; + } else if (doUpgrade) { + // Must wrap in quotes for Yaml parsing + versionToUse = "'>= $version'"; + } else { + versionToUse = version; + } + // final versionToUse = useAnyVersion || version.isEmpty ? 'any' : version; switch (kind) { case DependencyKind.unknown: case DependencyKind.overridden: @@ -1385,7 +1394,7 @@ String _generateFakePubspec( }) { final StringBuffer result = StringBuffer(); final StringBuffer overrides = StringBuffer(); - final bool verbose = useAnyVersion; + final bool verbose = doUpgrade; result.writeln('name: flutter_update_packages'); result.writeln('environment:'); result.writeln(" sdk: '>=2.10.0 <3.0.0'"); @@ -1415,7 +1424,7 @@ String _generateFakePubspec( } for (final PubspecDependency dependency in dependencies) { if (!dependency.pointsToSdk) { - dependency.describeForFakePubspec(result, overrides, useAnyVersion: useAnyVersion); + dependency.describeForFakePubspec(result, overrides, doUpgrade: doUpgrade); } } result.write(overrides.toString());