Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually added translation are not handled (replaced) #5

Open
LonnyX opened this issue Jul 5, 2018 · 1 comment
Open

Manually added translation are not handled (replaced) #5

LonnyX opened this issue Jul 5, 2018 · 1 comment

Comments

@LonnyX
Copy link

LonnyX commented Jul 5, 2018

Hello,

First, I would like to thank you for this tool, it's really easy to manage translations 👍

In order to improve the app, I will report a "bug" or a nice-to-have feature.
Sometime you want to translate the labels stored in your DB, so you have to put it manually on the *.json and it works.
After that, if you try to use Langly, it seems that these manually translations are not detected and if you click save, they will be lost.

Fix?

I think it's pretty simple, all you have to do is to merge the results of detection (on views files) with the current *.json

@christofferok
Copy link
Owner

HI @LonnyX,

Thank you for the feedback.

If you change the JSON file after it has been loaded in Langly you can hit "Reload" to load the file again.
Would this work for you?

I don't have capacity to add merge functionality for the use case where the file has been modified after it has been loaded by Langly. If this is something you would like to implement I would be happy to accept pull requests 👍

Thanks for understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants