Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-can 4.4.0 breaks canopen 2.2.0 #455

Closed
bjornolo opened this issue Jun 10, 2024 · 6 comments
Closed

python-can 4.4.0 breaks canopen 2.2.0 #455

bjornolo opened this issue Jun 10, 2024 · 6 comments
Labels

Comments

@bjornolo
Copy link

CANopen automaticall gets the latest python-can 4.4.0 wich gives error:

TypeError: Can't instantiate abstract class MessageListener without an implementation for abstract method 'stop'

Reveting back to python-can 4.3.1 fixes issue

@acolomb
Copy link
Collaborator

acolomb commented Jun 10, 2024

It's a known issue and already fixed on master. We just haven't got around to making a new release yet.

@acolomb
Copy link
Collaborator

acolomb commented Jun 10, 2024

See #422.

@acolomb acolomb changed the title pyhton-can 4.4.0 breaks canopen 2.2.0 python-can 4.4.0 breaks canopen 2.2.0 Jun 11, 2024
@acolomb acolomb added the bug label Jun 11, 2024
@acolomb
Copy link
Collaborator

acolomb commented Jun 12, 2024

This issue is intentionally kept open until the upcoming v2.3.0 release is out, so other users with the same problem can find it quickly.

@acolomb acolomb reopened this Jun 12, 2024
@acolomb
Copy link
Collaborator

acolomb commented Jun 13, 2024

Note that hardbyte/python-can#1795 is already merged and will avoid this pitfall. Dunno when that will land in a release on PyPI though, so we should still try to fix it soon on our end.

@christiansandberg I could make a release pretty soon, do I have your approval? Not sure what needs to be done beyond the GitHub release though, will it land on PyPI automatically?

@christiansandberg
Copy link
Owner

@acolomb go ahead and make a release if possible. It's nice to see so much activity but I haven't had the time to check all changes.

I hope it should automatically push to pypi but if not I can do it manually.

@acolomb
Copy link
Collaborator

acolomb commented Jun 13, 2024

Alrighty, PyPI now has version 2.3.0, but Read The Docs hasn't picked it up yet. Noted a small mistake just after the release: README still stated Python >=3.6 support, but that is now fixed on master at least. The release notes do mention the upped dependency.

@acolomb acolomb closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants