Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve data check by only checking used columns #54

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

chrislemke
Copy link
Owner

No description provided.

@chrislemke chrislemke requested a review from premsrii January 20, 2023 11:52
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #54 (ea7bec4) into develop (7636d70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #54   +/-   ##
========================================
  Coverage    99.30%   99.31%           
========================================
  Files            9        9           
  Lines          434      436    +2     
========================================
+ Hits           431      433    +2     
  Misses           3        3           
Impacted Files Coverage Δ
src/sk_transformers/generic_transformer.py 99.24% <100.00%> (ø)
src/sk_transformers/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chrislemke chrislemke merged commit ca450a4 into develop Jan 20, 2023
@chrislemke chrislemke deleted the improve_data_check branch January 20, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants