diff --git a/.github/workflows/auto-comment.yml b/.github/workflows/auto-comment.yml new file mode 100644 index 0000000..95feb48 --- /dev/null +++ b/.github/workflows/auto-comment.yml @@ -0,0 +1,28 @@ +name: AutoComment +on: [issues, pull_request] +jobs: + run: + runs-on: ubuntu-latest + steps: + - uses: wow-actions/auto-comment@v1 + with: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + issuesOpened: | + 👋 @{{ author }} + Thank you for raising an issue. We will will investigate into the matter and get back to you as soon as possible. + Please make sure you have given us as much context as possible. + pullRequestOpened: | + ⚠️ ⚠️ ⚠️ + + 👋 @{{ author }} + Please remember that we use [**fast-forward merge**](https://git-scm.com/docs/git-merge#Documentation/git-merge.txt---ff-only) instead of using the usual *Create a merge commit*, *squash and merge* or *rebase and merge* for merging `develop` into `main` or vice versa. + You can execute it by creating a new comment in this PR with the following content: + ``` + fast-forward + ``` + ***With an additional slash (`/`) before the command.*** + **Please create this comment only after all tests have been completed positively!** + + For merging your feature branch to `develop` please use [*squash and merge*](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits). + + Thanks! 🙏 diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml deleted file mode 100644 index 658e19b..0000000 --- a/.github/workflows/pre-commit.yml +++ /dev/null @@ -1,28 +0,0 @@ -name: PreCommit - -on: - pull_request: - branches: [develop] - -jobs: - pre-commit: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - name: Install poetry - run: | - curl -O -sSL https://install.python-poetry.org/install-poetry.py - python install-poetry.py -y --version 1.3.1 - echo "PATH=${HOME}/.poetry/bin:${PATH}" >> $GITHUB_ENV - rm install-poetry.py - - uses: actions/setup-python@v4 - with: - python-version: "3.10" - cache: "poetry" - - name: Install dependencies and project - run: | - poetry env use python3.10 - poetry install - - uses: pre-commit/action@v3.0.0 - env: - SKIP: poetry-lock,poetry-export diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index c727e87..a1f4378 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,9 @@ default_language_version: python: python3.10 +ci: + skip: [poetry-lock, poetry-export] + repos: - repo: https://github.com/compilerla/conventional-pre-commit rev: v2.1.1 diff --git a/docs/README.md b/docs/README.md index e882913..fb1b4ed 100644 --- a/docs/README.md +++ b/docs/README.md @@ -4,6 +4,7 @@ ***A collection of various pandas & scikit-learn compatible transformers for all kinds of preprocessing and feature engineering steps*** 🛠 [![testing](https://github.com/chrislemke/sk-transformers/actions/workflows/testing.yml/badge.svg?branch=main)](https://github.com/chrislemke/sk-transformers/actions/workflows/testing.yml) +[![Codacy Badge](https://app.codacy.com/project/badge/Grade/44093b8f6b28454fb8e0336ccb83cdc5)](https://www.codacy.com/gh/chrislemke/sk-transformers/dashboard?utm_source=github.com&utm_medium=referral&utm_content=chrislemke/sk-transformers&utm_campaign=Badge_Grade) [![codecov](https://codecov.io/github/chrislemke/sk-transformers/branch/main/graph/badge.svg?token=LJLXQXX6M8)](https://codecov.io/github/chrislemke/sk-transformers) [![deploy package](https://github.com/chrislemke/sk-transformers/actions/workflows/deploy-package.yml/badge.svg)](https://github.com/chrislemke/sk-transformers/actions/workflows/deploy-package.yml) [![pypi](https://img.shields.io/pypi/v/sk-transformers)](https://pypi.org/project/sk-transformers/) diff --git a/src/sk_transformers/utils.py b/src/sk_transformers/utils.py index 5501b15..2787056 100644 --- a/src/sk_transformers/utils.py +++ b/src/sk_transformers/utils.py @@ -33,7 +33,6 @@ def check_ready_to_transform( ValueError: If the input `X` does not contain the feature. ValueError: if the input `X` does not contain all features. - Returns: pandas.DataFrame: A checked copy of original dataframe. """