diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index ca7bdc6..c10ca60 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -1,7 +1,7 @@ name: PRCheck on: pull_request_target: - types: [opened, edited, reopened] + types: [opened, edited, synchronize, reopened] permissions: contents: read diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 52739b2..ee5a1e8 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -69,7 +69,7 @@ repos: - id: text-unicode-replacement-char - repo: https://github.com/PyCQA/docformatter - rev: v1.5.1 + rev: v1.6.0.rc1 hooks: - id: docformatter @@ -105,7 +105,7 @@ repos: args: ["--profile=black"] - repo: https://github.com/PyCQA/pylint - rev: v2.15.10 + rev: v2.16.0b1 hooks: - id: pylint args: ["--rcfile=pyproject.toml"] diff --git a/src/sk_transformers/datetime_transformer.py b/src/sk_transformers/datetime_transformer.py index e00d0e9..38425a9 100644 --- a/src/sk_transformers/datetime_transformer.py +++ b/src/sk_transformers/datetime_transformer.py @@ -167,7 +167,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: The transformed DataFrame. """ - X = check_ready_to_transform(self, X, list(self.features)) duration_series = pd.to_datetime( @@ -225,7 +224,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: Dataframe with transformed columns. """ - X = check_ready_to_transform(self, X, self.features) for column in self.features: diff --git a/src/sk_transformers/deep_transformer.py b/src/sk_transformers/deep_transformer.py index ce4d6d8..7721f88 100644 --- a/src/sk_transformers/deep_transformer.py +++ b/src/sk_transformers/deep_transformer.py @@ -112,7 +112,6 @@ def fit(self, X: pd.DataFrame, y: NDArray) -> "ToVecTransformer": Returns: ToVecTransformer: The fitted transformer. """ - self.fitted_ = True preprocessor = TabPreprocessor( @@ -164,7 +163,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pd.DataFrame: The embeddings. """ - X = check_ready_to_transform( self, X, diff --git a/src/sk_transformers/generic_transformer.py b/src/sk_transformers/generic_transformer.py index 53a550c..830dc7d 100644 --- a/src/sk_transformers/generic_transformer.py +++ b/src/sk_transformers/generic_transformer.py @@ -55,7 +55,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: Transformed dataframe. """ - X = check_ready_to_transform( self, X, @@ -212,7 +211,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pd.DataFrame: Transformed dataframe. It contains the original columns and the new columns created by this transformer. """ - X = check_ready_to_transform( self, X, @@ -292,7 +290,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: The original dataframe with the modified columns. """ - X = check_ready_to_transform(self, X, [feature[0] for feature in self.features]) for (column, func, kwargs) in self.features: @@ -344,7 +341,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: pandas.DataFrame: The dataframe containing the new column together with the non-transformed original columns. """ - X = check_ready_to_transform(self, X, [feature[0] for feature in self.features]) for (feature, callback) in self.features: @@ -543,7 +539,6 @@ def transform(self, Xy: pd.DataFrame) -> pd.DataFrame: Returns: pd.DataFrame: Dataframe with the queries applied. """ - Xy = check_ready_to_transform( self, Xy, Xy.columns, force_all_finite="allow-nan" ) @@ -609,7 +604,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pd.DataFrame: Dataframe with replaced values. """ - X = check_ready_to_transform( self, X, [feature[0][0] for feature in self.features] ) @@ -688,7 +682,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pd.DataFrame: Dataframe joined on the given columns. """ - X = check_ready_to_transform( self, X, @@ -757,7 +750,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pd.DataFrame: Dataframe with replaced values. """ - X = check_ready_to_transform( self, X, diff --git a/src/sk_transformers/number_transformer.py b/src/sk_transformers/number_transformer.py index 15d1045..f5627a8 100644 --- a/src/sk_transformers/number_transformer.py +++ b/src/sk_transformers/number_transformer.py @@ -81,7 +81,6 @@ def __abbreviate_numpy_in_operation(self, operation: str) -> str: Returns: str: The operation as a string with numpy replaced with np. """ - if operation.startswith("numpy"): operation = "np" + operation[5:] return operation @@ -96,7 +95,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: pandas.DataFrame: The original dataframe with the new columns. The new columns are named as follows: '`column_name`_`operation`_`value`' or '`column_name`_`operation`' if `value` is `None`. """ - X = check_ready_to_transform(self, X, [feature[0] for feature in self.features]) for (feature, operation, value, kwargs) in self.features: diff --git a/src/sk_transformers/string_transformer.py b/src/sk_transformers/string_transformer.py index d3d40b8..bac2d32 100644 --- a/src/sk_transformers/string_transformer.py +++ b/src/sk_transformers/string_transformer.py @@ -64,7 +64,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: Transformed dataframe. """ - X = check_ready_to_transform(self, X, self.features) function = functools.partial( @@ -132,7 +131,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: Transformed dataframe containing the extra columns. """ - X = check_ready_to_transform(self, X, self.features) for column in self.features: @@ -221,7 +219,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: Original dataframe containing the extra column with the calculated similarity. """ - X = check_ready_to_transform(self, X, list(self.features)) X[f"{self.features[0]}_{self.features[1]}_similarity"] = X[ @@ -297,7 +294,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: Original dataframe containing the extra column with the calculated similarity. """ - X = check_ready_to_transform(self, X, self.features) for column in self.features: @@ -382,7 +378,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: Returns: pandas.DataFrame: Original dataframe with sliced strings in specified features. """ - X = check_ready_to_transform(self, X, [feature[0] for feature in self.features]) for feature, slice_args in self.features: @@ -441,7 +436,6 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: pandas.DataFrame: Dataframe containing additional columns containing each split part of the string. """ - X = check_ready_to_transform(self, X, [feature[0] for feature in self.features]) for column, separator, maxsplit in self.features: