MongoDB transactions are not checked for success

[uhliksk]

Version

v0.0.88 (9c2e4f5)

Description

MongoDB transactions will fail silently which can cause there are some buy or sell orders not recorded or grid trade is not reset after last sell order is executed.

To Reproduce

It appear occasionally even under light workload. I didn't found specific steps to reproduce.

Expected Behaviours

Retryable transactions should be retried if the first attempt failed or at least the user should be warned there was a failed transaction.

Screenshots

Additional context

There is no check if transaction has been processed successfully. Result is returned but not processed.

binance-trading-bot/app/cronjob/trailingTradeHelper/configuration.js

Lines 522 to 530 in a9319ad

	const deleteSymbolGridTrade = async (logger, symbol) => {
	const result = await mongo.deleteOne(logger, 'trailing-trade-grid-trade', {
	key: `${symbol}`
	});
	await cache.hdel('trailing-trade-configurations', symbol);
	return result;
	};

binance-trading-bot/app/cronjob/trailingTrade/step/remove-last-buy-price.js

Lines 128 to 129 in a9319ad

	// Delete symbol grid trade
	await deleteSymbolGridTrade(logger, symbol);

There is not even writeConcern enabled. Transactions will fail silently. Introduced in #288 as "risky but worth" for RPi. Maybe it should be platform specific?

binance-trading-bot/app/helpers/mongo.js

Lines 231 to 237 in a9319ad

	const result = collection.deleteOne(filter, {
	// https://docs.mongodb.com/v3.2/reference/write-concern/
	writeConcern: {
	w: 0,
	j: false
	}
	});