Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination is not compliant with standard pagination methods #437

Closed
uhliksk opened this issue Jul 27, 2022 · 0 comments · Fixed by #452
Closed

Pagination is not compliant with standard pagination methods #437

uhliksk opened this issue Jul 27, 2022 · 0 comments · Fixed by #452
Labels
bug Something isn't working

Comments

@uhliksk
Copy link
Contributor

uhliksk commented Jul 27, 2022

Version

v0.0.88 (9c2e4f5)

Description

Pagination with less than 3 or 8 pages is showing also unused and disabled pages. Moving to the right will mark second button active even when much more buttons for paging are visible on the right. At the end it will show more pages than actually exists which is confusing.

To Reproduce

  • List more than 12 symbols.
  • List closed trades with more than 5 items.
  • List closed trades for symbol with more than 5 items.
  • List logs for symbol with more than 20 items.

Expected Behaviours

  • It should not show more buttons than actually available.
  • It should not show buttons beyond total number of pages.
  • It should keep marked button centered in the list with more than 3 buttons in pagination object.

Screenshots

Even with just single page available there are three buttons visible with last two buttons disabled.

image

Additional context

The design decision should be made to use pagination centered only or on the left side only for all pagination use in the application.

@uhliksk uhliksk added the bug Something isn't working label Jul 27, 2022
@chrisleekr chrisleekr linked a pull request Aug 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant