Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UE incompatible with pythonssss Preset Text node #154

Open
chrisgoringe opened this issue Mar 18, 2024 · 2 comments
Open

UE incompatible with pythonssss Preset Text node #154

chrisgoringe opened this issue Mar 18, 2024 · 2 comments
Labels
bug Something isn't working compatibility working with other nodes
Milestone
5.2

Comments

@chrisgoringe
Copy link
Owner

If the Preset Text node is connected to a UE node, it breaks.

image

It seems to be because the Preset Text node isn't serialized (it's pure javascript) but UE references it. Push it through a blank String node and it's fine. My initial guess is that Preset works by pushing it's value into the downstream nodes in a way that UE doesn't support.

image
@chrisgoringe chrisgoringe mentioned this issue Mar 18, 2024
Closed
@chrisgoringe chrisgoringe added bug Something isn't working compatibility working with other nodes labels Mar 18, 2024
@chrisgoringe
Copy link
Owner Author

Yup - at presetText.js:145

// For each output link copy our value over the original widget value

@chrisgoringe
Copy link
Owner Author

I've made a suggestion to the author of pythonsssss that we could fix this collaboratively.

pythongosssss/ComfyUI-Custom-Scripts#210

@chrisgoringe chrisgoringe added this to the 5.2 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compatibility working with other nodes
Projects
None yet
Milestone
5.2
Development

No branches or pull requests
1 participant
@chrisgoringe