Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Taproot #263

Open
benma opened this issue Mar 18, 2022 · 8 comments
Open

support Taproot #263

benma opened this issue Mar 18, 2022 · 8 comments

Comments

@benma
Copy link

benma commented Mar 18, 2022

The BitBoxApp supports Taproot receive addresses since the last release. BitBoxApp users who use EPS now get warnings like Address not known to server.

It would be great if they could configure EPS to track Taproot addresses from an xpub/descriptor.

@chris-belcher
Copy link
Owner

Thanks for the issue.

Good idea. I wasn't aware of BitBox.

Do you know if they have any documentation for their taproot? For example what does the master public key format look like

@benma
Copy link
Author

benma commented Mar 19, 2022

Currently it's just a plain xpub... string, but we could easily turn it into a descriptor if it helps, e.g. as proposed in spesmilo/electrum#7544 (comment). I don't think anyone plans on continuing with the ypub... and zpub... versioning scheme.

@micressor
Copy link

@chris-belcher Let me know as soon as you have a patch. I have exactly this problem and can test it.

@benma
Copy link
Author

benma commented Mar 25, 2022

It seems internally, descriptors are used already:

It looks like extending this to accept descriptors directly from the config is the way to go, and would make EPS more flexible and forwards-compatible. @chris-belcher do you plan to work on it?

@chris-belcher
Copy link
Owner

I don't plan to work on it for at least several months.

I'd prefer not to have the config file use descriptors instead of xpub ypub zpub, because Electrum's GUI doesn't use them. Right now the instructions to Electrum users are simple as they have to click Wallet -> Information and then copypaste the master public key into the config file.

@benma
Copy link
Author

benma commented Mar 26, 2022

There is no need to remove support for xpub ypub zpub, but it would help to also parse descriptors additionally. Electrum will likely use descriptors as well, at least for their Taproot wallets.

Fyi, Electrum is not the only wallet using Electrum backends, many wallets do.

@micressor
Copy link

@chris-belcher I use both wallets (electrum and BitBoxApp). If EPS is not patched, sooner or later I will be forced to use another implementation.

I do not use taproot addresses at the moment. But I can't work with the latest version of BitBoxApp because EPS brings this error and disconnects.

@chris-belcher
Copy link
Owner

Ah I see, yes adding additional ways to tell EPS about addresses to watch is fine. As long as it continues to work for Electrum users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants