Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl missing not resulting in error message when calling :TypstPreviewUpdate #49

Closed
asmund20 opened this issue Aug 25, 2024 · 0 comments · Fixed by #58
Closed

Curl missing not resulting in error message when calling :TypstPreviewUpdate #49

asmund20 opened this issue Aug 25, 2024 · 0 comments · Fixed by #58

Comments

@asmund20
Copy link
Contributor

Running :TypstPreviewUpdate on a system without curl installed does not result in an error message, at least that was the case with my Ubuntu 24.04 TLS and neovim 0.10.1.

I was going to try making a PR for this, but as far as I can tell, the

vim.loop.spawn('curl' ...

on line 130 in fetch should result in an exit code that is non-zero and thus an error-message logged. Due to me not really understaning what is going on, I am making this issue hoping that someone fixes it, or that it can help others with the same problems.

It could be enough to clarify that curl is a dependency in the readme/docs, but would be nice to have error-handling for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant