Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinymist preview feature not yet released #47

Closed
asmund20 opened this issue Aug 22, 2024 · 11 comments
Closed

Tinymist preview feature not yet released #47

asmund20 opened this issue Aug 22, 2024 · 11 comments

Comments

@asmund20
Copy link
Contributor

asmund20 commented Aug 22, 2024

Please release the tinymist preview feature!

The tinymist binary has some useful features, for example the preview feature added to the docs in #46.

The feature is committed to the master branch (and therefore I assume that it works). There is, however not a release including this feature yet. That is confusing, as it is added to both the readme and docs and does not work (results in unexpexted arguments because it does not call tinymist preview ..args but just tinymist ..args without the support added in #43.

@asmund20
Copy link
Contributor Author

I recommend removing the tag=0.3.* from the install to use the newly committed features even though they are not released yet.

@max397574
Copy link
Contributor

every user can just remove that themselves in their config

@chomosuke
Copy link
Owner

Hey sorry, I did not realize I was so far behind in my release! I think everytime I merge a PR I tell myself I'll release it later but I never do, I will start improving in this from now on.

And sorry for the late reply, I've been finding myself in lack of motivation to maintain this plugin this year since I dropped out of my research and am no longer using typst. There's quite a lot of to-do for this plugin that I need to attend to.

@max397574
Copy link
Contributor

@chomosuke

  1. you could use release please
  2. Would you mind me rewriting this plugin as a new plugin? I thought about this anyway but since you're not rly maintaining it anymore that's even more reason todo so

@chomosuke
Copy link
Owner

@max397574

  1. I have just released.
  2. Would you like to become the maintainer of this plugin instead? If you do use typst on a daily basis you'll probably do a better job than me. You can also rewrite the plugin however you like.

@max397574
Copy link
Contributor

I use typst for multiple hours every day so I make really heavy use of this plugin. I'll take a look at the codebase first before I decide what to do

@max397574
Copy link
Contributor

@chomosuke would you be okay with me adding this to a plugin I'm working on: typst-tools.nvim?
also has various utils some lsp,treesitter stuff, snippets etc

I'd copy over most of the code and ofc course give credits to you in the readme

@chomosuke
Copy link
Owner

Hi @max397574, would you like to add this plugin as a dependency instead? That way people who only want the preview can still get only the preview.

@max397574
Copy link
Contributor

if I'd copy over the things this plugin would still exist for people who only want preview

@chomosuke
Copy link
Owner

Oh yes indeed, that make sense. Yes I don't mind feel free.

@chomosuke
Copy link
Owner

I wonder if this plugin will still be necessary once typst-tools is completed. I also don't think that many people would want to use preview only without the language server. On a second thought, something like typst-tools.nvim really make much more sense now that tinymist exist. I will consider sunsetting typst-preview.nvim just like Enter-tainer has done to typst-preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants