Skip to content

Parting Multipart, but not all JSON #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indexzero opened this issue Feb 13, 2013 · 1 comment
Open

Parting Multipart, but not all JSON #9

indexzero opened this issue Feb 13, 2013 · 1 comment

Comments

@indexzero
Copy link

@chjj I've wanted to implement this in nodejitsu for a while, but haven't found a reliable multipart implementation to use:

  • Currently a user has to call PUT application/json apps/:user/:app to update the app document and then do PUT application/x-tar-gz apps/:user/:app/snapshot/:version to add the tarball.
  • Would be nice if we could just PUT multipart apps/:user/:app/snapshot/:version with both the app document updates and the tarball

Is this possible in parted?

@chjj
Copy link
Owner

chjj commented Feb 13, 2013

Yeah. Definitely possible with parted, or any multipart parser really.

One thing to consider though: since we're not really using that API in the browser at all, it might not be worth the overhead of parsing everything. A raw file in the request body of a PUT will always be faster than parsing multipart, but then again it is one less request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants