-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Stage 1 - add parseConfig field to Question and OptionChoice models #238
Conversation
I don't think form needs a parse option (I know it's in the docs, maybe I was thinking something else when I wrote that, sorry) The parseOption for choices should be in the option choice model as the options are pulled from there, the group itself won't need one (it's used to group all the options for the same question) |
So we only want it on the |
That and question. Anywhere with these things So when frontend pull the questions, they will also pull the parseOption Json field in the same table, they use use that to reconstruct the questions like so, GET /forms the response will look like this
instead of what we have now,
|
- Modify rocket status icons to use icon and iconUrl properties - Update boolean and NPS scale options to use more generic min/max keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
db push and re-seed ✅
ran all tests ✅
Description
Added parseConfig JSON field to Question and OptionChoice models to support dynamic text parsing functionality. This enhancement allows for configurable text substitutions in form questions and option choices, improving the flexibility of form content management.
Key changes:
Issue link
Fixes # clickup task 86b3u7wv2
Type of change
How Has This Been Tested?
Database Migration Tests:
Unit Tests:
Seed Data Validation:
Checklist: