Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYN files are not validated before uploading to the instrument #73

Closed
chinenual opened this issue Apr 25, 2022 · 0 comments
Closed

SYN files are not validated before uploading to the instrument #73

chinenual opened this issue Apr 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@chinenual
Copy link
Owner

A SYN file has an embedded checksum. That value is checked when downloading the SYN from the instrument, but it is not currently checked when uploading a SYN to the instrument, or when analyzing the SYN to create MIDI through the new MIDI converter.

Add a validation when loading a SYN from disk to ensure it's really a SYN file (or that the SYN file hasn't been corrupted)
@chinenual chinenual added the enhancement New feature or request label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chinenual