Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejitsu/node-http-proxy is dead. Would you consider switching? #214

Open
RichAyotte opened this issue Oct 26, 2017 · 3 comments
Open

nodejitsu/node-http-proxy is dead. Would you consider switching? #214

RichAyotte opened this issue Oct 26, 2017 · 3 comments

Comments

@RichAyotte
Copy link

With the last code commit made Dec 6, 2016, and 49 PR in the queue, I'm ready to declare nodejitsu/node-http-proxy dead.

Would you consider using nxtedition/node-http2-proxy instead?

@chimurai
Copy link
Owner

Hi @RichAyotte,

Thanks for spotting node-http2-proxy.

Think any healthy competition is always welcome.

Is there a good comparison for the two libraries?

@RichAyotte
Copy link
Author

The project is new and I believe it arose out of the need for http2 support. Perhaps @ronag can tell us more?

@ronag
Copy link

ronag commented Oct 30, 2017

@RichAyotte it was built with http2 support, simplicity, and performance in mind.

The API is much smaller and simpler than node-http-proxy. So if there might be some feature that http-proxy-middleware depends on that would have to be implemented inside http-proxy-middleware instead.

Performance wise it has almost zero overhead with as far as I can tell no extra allocations (no closures etc...) that V8 is not able to optimize away.

Also, I believe it much closer follows the HTTP spec for proxy behavior.

Though, you should note that node-http-proxy is much more tested and has lots of unit tests to avoid regressions (which node-http2-proxy doesn't have yet). On the other hand node-http2-proxy is much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants