Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provision mainnet account for customers on account bootstrap [DEV-4203] #567

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

jay-dee7
Copy link
Contributor

@jay-dee7 jay-dee7 commented Aug 6, 2024

No description provided.

@jay-dee7 jay-dee7 self-assigned this Aug 6, 2024
@Tweeddalex Tweeddalex changed the title feat: Provision mainnet account for customers on account bootstrap feat: Provision mainnet account for customers on account bootstrap [DEV-4203] Aug 6, 2024
@ankurdotb
Copy link
Contributor

@jay-dee7 jay-dee7 marked this pull request as ready for review August 6, 2024 07:18
@jay-dee7 jay-dee7 requested a review from DaevMithran August 6, 2024 07:18
Copy link
Contributor

@DaevMithran DaevMithran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provisionCustomerAccount should also be used in /account/create api here.

@DaevMithran
Copy link
Contributor

DaevMithran commented Aug 6, 2024

Lets return both the payment addresses in GET /account api here. If mainnet address is not available we can return a null for staging environments.

@jay-dee7 jay-dee7 force-pushed the feat/mainnet-account-provision-on-bootstrap branch from 3939e92 to 6765931 Compare August 6, 2024 08:42
@jay-dee7 jay-dee7 force-pushed the feat/mainnet-account-provision-on-bootstrap branch from b353db4 to 273ebb8 Compare August 6, 2024 09:26
@jay-dee7 jay-dee7 force-pushed the feat/mainnet-account-provision-on-bootstrap branch from 152c946 to b4a314c Compare August 6, 2024 10:22
DaevMithran
DaevMithran previously approved these changes Aug 6, 2024
ankurdotb
ankurdotb previously approved these changes Aug 6, 2024
@jay-dee7 jay-dee7 dismissed stale reviews from ankurdotb and DaevMithran via 8ca0de7 August 6, 2024 10:59
@ankurdotb ankurdotb merged commit 3ad0955 into develop Aug 6, 2024
13 checks passed
@ankurdotb ankurdotb deleted the feat/mainnet-account-provision-on-bootstrap branch August 6, 2024 11:18
cheqd-bot bot pushed a commit that referenced this pull request Aug 6, 2024
## [3.2.0-develop.1](3.1.0...3.2.0-develop.1) (2024-08-06)

### Features

* Provision mainnet account for customers on account bootstrap [DEV-4203] ([#567](#567)) ([3ad0955](3ad0955))
@cheqd-bot
Copy link

cheqd-bot bot commented Aug 6, 2024

🎉 This PR is included in version 3.2.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Aug 6, 2024
## [3.2.0](3.1.0...3.2.0) (2024-08-06)

### Features

* Provision mainnet account for customers on account bootstrap [DEV-4203] ([#567](#567)) ([3ad0955](3ad0955))
@cheqd-bot
Copy link

cheqd-bot bot commented Aug 6, 2024

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants