feat: Synchronising stripe and studio API state - [DEV-4157] #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-dee7
force-pushed
the
chore/add-local-dev-mode
branch
from
bb51721 to
4f32d08
Compare
Signed-off-by: jay-dee7 <[email protected]>
Signed-off-by: jay-dee7 <[email protected]>
subscriptions Signed-off-by: jay-dee7 <[email protected]>
…` event Signed-off-by: jay-dee7 <[email protected]>
jay-dee7
force-pushed
the
chore/add-local-dev-mode
branch
from
5732a42 to
241f6e4
Compare
Signed-off-by: jay-dee7 <[email protected]>
jay-dee7
force-pushed
the
chore/add-local-dev-mode
branch
from
241f6e4 to
3622762
Compare
jay-dee7
changed the title
Signed-off-by: jay-dee7 <[email protected]>
DaevMithran
reviewed
Jul 30, 2024
|
@jay-dee7 |
DaevMithran
reviewed
Jul 30, 2024
@DaevMithran we can't remove it. To implement |
Signed-off-by: jay-dee7 <[email protected]>
DaevMithran
approved these changes
Jul 30, 2024
jay-dee7
changed the title
cheqd-bot bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
## [3.1.0-develop.1](3.0.1-develop.2...3.1.0-develop.1) (2024-07-31) ### Features * Synchronising stripe and studio API state - [DEV-4157] ([#561](#561)) ([f338db7](f338db7))
|
🎉 This PR is included in version 3.1.0-develop.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
cheqd-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
## [3.1.0](3.0.0...3.1.0) (2024-08-05) ### Features * Switch logto role assignment to subscription webhook [DEV-4164] ([#565](#565)) ([0b93908](0b93908)) * Synchronising stripe and studio API state - [DEV-4157] ([#561](#561)) ([f338db7](f338db7)) ### Bug Fixes * Return proper response on auth setup [DEV-4146] ([#560](#560)) ([690d854](690d854)) * trigger stripe account creation on sign-in ([#559](#559)) ([d2fec93](d2fec93)) * Use `admin:subscription:get` auth guard for Stripe checkout session ([#564](#564)) ([fc631e4](fc631e4))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes few adjustments and breaks existing assumptions about the user journeys for Stripe and our API.
We now create a customer (Studio) when someone subscribes on Stripe but has never signed up for our platform. This helps with
Inbound Billing JourneyWe still try to maintain consistency at runtime about 1-1 relationship between the
userandcustomertables. Though it's quite risky since the underlying database does not guarantee the relation terms. We could end up creating multiple customers in some edge case as long as it's not implemented at the database layer. The first step for this should be marking thecustomer.emailas the primary or at least a unique column.Allow setting the
paymentProviderIdwhile creating new Customer entity records, it was optional before anyway and we only allow to create it optionally (to avoid having to perform a create + update operation)New endpoint -
GET /admin/checkout/session/:idAPI to retrieve Stripe checkout session by IDWarning
The get Stripe checkout session endpoint is completely open at the source (API) this of course does require some thinking but the times when this endpoint becomes useful is mostly when user is not authenticated. One thing we could do is make thisauthenticatedand force a user login before performing any checks on client side.