Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add did import api [DEV-3487] #457

Merged
merged 11 commits into from
Jan 4, 2024
Merged

feat: Add did import api [DEV-3487] #457

merged 11 commits into from
Jan 4, 2024

Conversation

DaevMithran
Copy link
Contributor

@DaevMithran DaevMithran commented Jan 2, 2024 •
edited
Loading

This PR includes the addition of did/import api

At the moment it requires all the keys in the didDocument to be passed in the request, The ability to handle existing keys in wallet will be supported once the addition of that feature is complete in veramo, Created a feature request here decentralized-identity/veramo#1312

@ankurdotb
Copy link
Contributor

Task linked: DEV-3487 Add did/import api

@DaevMithran DaevMithran requested a review from Eengineer1 January 3, 2024 14:02
Eengineer1
Eengineer1 requested changes Jan 4, 2024
View reviewed changes
src/services/identity/local.ts Outdated Show resolved Hide resolved
src/services/identity/agent.ts Outdated Show resolved Hide resolved
src/services/identity/index.ts Outdated
importDid(
did: string,
keys: Pick<IKey, 'privateKeyHex' | 'type'>[],
controllerKeyId: string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same logic applies here.

src/services/identity/postgres.ts Outdated Show resolved Hide resolved
src/app.ts Outdated Show resolved Hide resolved
@DaevMithran DaevMithran requested review from Eengineer1 and removed request for lampkin-diet January 4, 2024 13:08
Eengineer1
Eengineer1 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Approved.

@DaevMithran DaevMithran merged commit 75232f0 into develop Jan 4, 2024
7 of 9 checks passed
@DaevMithran DaevMithran deleted the did-import branch January 4, 2024 16:43
cheqd-bot bot pushed a commit that referenced this pull request Jan 4, 2024
@semantic-release-bot
chore(release): 2.15.0-develop.1 [skip ci]
3323e23 
## [2.15.0-develop.1](2.14.0...2.15.0-develop.1) (2024-01-04)

### Features

* Add did import api [DEV-3487] ([#457](#457)) ([75232f0](75232f0))

### Bug Fixes

* Removed redundant import ([6f10d61](6f10d61))
@cheqd-bot
Copy link

cheqd-bot bot commented Jan 4, 2024

🎉 This PR is included in version 2.15.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Jan 5, 2024
@semantic-release-bot
chore(release): 2.15.0 [skip ci]
814c2f2 
## [2.15.0](2.14.0...2.15.0) (2024-01-05)

### Features

* Add did import api [DEV-3487] ([#457](#457)) ([75232f0](75232f0))

### Bug Fixes

* Removed redundant import ([6f10d61](6f10d61))
* Support did:vda in validator [DEV-3498] ([#459](#459)) ([2176e84](2176e84))
@cheqd-bot
Copy link

cheqd-bot bot commented Jan 5, 2024

🎉 This PR is included in version 2.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eengineer1 Eengineer1 Eengineer1 approved these changes

Assignees
No one assigned
Labels
released on @beta released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaevMithran @ankurdotb @Eengineer1