Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add makeFeePayment for /presentation/verify [DEV-3400] #429

Merged
merged 30 commits into from
Dec 8, 2023

Conversation

lampkin-diet
Copy link
Contributor

No description provided.

@ankurdotb
Copy link
Contributor

Copy link

gitguardian bot commented Nov 27, 2023

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7902530 Generic High Entropy Secret 2f7da09 src/test/constants.ts View secret
7902530 Generic High Entropy Secret fbaa097 src/test/constants.ts View secret
8882677 Generic High Entropy Secret 2f7da09 src/test/constants.ts View secret
8882677 Generic High Entropy Secret 4733047 src/test/constants.ts View secret
8882677 Generic High Entropy Secret fbaa097 src/test/constants.ts View secret
8882677 Generic High Entropy Secret fbaa097 src/test/constants.ts View secret
8882677 Generic High Entropy Secret 79e9ff7 src/test/constants.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

src/controllers/presentation.ts Outdated Show resolved Hide resolved
src/types/presentation.ts Outdated Show resolved Hide resolved
src/types/presentation.ts Outdated Show resolved Hide resolved
src/controllers/presentation.ts Outdated Show resolved Hide resolved
src/types/credential.ts Outdated Show resolved Hide resolved
src/controllers/presentation.ts Outdated Show resolved Hide resolved
src/controllers/presentation.ts Outdated Show resolved Hide resolved
src/controllers/presentation.ts Show resolved Hide resolved
src/controllers/presentation.ts Show resolved Hide resolved
src/controllers/presentation.ts Show resolved Hide resolved
src/controllers/presentation.ts Show resolved Hide resolved
src/test/constants.ts Outdated Show resolved Hide resolved
src/types/swagger-types.ts Show resolved Hide resolved
tests/helpers.ts Outdated Show resolved Hide resolved
tests/presentation/verify.negative.spec.ts Outdated Show resolved Hide resolved
tests/presentation/verify.positive.spec.ts Outdated Show resolved Hide resolved
@Eengineer1
Copy link
Contributor

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request

GitGuardian id Secret Commit Filename
7902530 Generic High Entropy Secret 2f7da09 src/test/constants.ts View secret
7902530 Generic High Entropy Secret fbaa097 src/test/constants.ts View secret
🛠 Guidelines to remediate hardcoded secrets

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

Unnecessary, as false positive on presentation JWTs.

@Eengineer1 Eengineer1 self-requested a review December 8, 2023 14:12
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks well polished.

Approved.

@lampkin-diet lampkin-diet merged commit 940f9fa into develop Dec 8, 2023
@lampkin-diet lampkin-diet deleted the DEV-3400 branch December 8, 2023 17:39
cheqd-bot bot pushed a commit that referenced this pull request Dec 8, 2023
## [2.12.0-develop.1](2.11.0...2.12.0-develop.1) (2023-12-08)

### Features

* Add makeFeePayment for /presentation/verify [DEV-3400] ([#429](#429)) ([940f9fa](940f9fa)), closes [#435](#435)
@cheqd-bot
Copy link

cheqd-bot bot commented Dec 8, 2023

🎉 This PR is included in version 2.12.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lampkin-diet lampkin-diet restored the DEV-3400 branch December 12, 2023 11:35
@lampkin-diet lampkin-diet deleted the DEV-3400 branch December 12, 2023 11:36
cheqd-bot bot pushed a commit that referenced this pull request Dec 20, 2023
## [2.12.0](2.11.0...2.12.0) (2023-12-20)

### Features

* Add makeFeePayment for /presentation/verify [DEV-3400] ([#429](#429)) ([940f9fa](940f9fa)), closes [#435](#435)
@cheqd-bot
Copy link

cheqd-bot bot commented Dec 20, 2023

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants