Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change from did/:did to did/search/:didUrl endpoint and support query parameters for DID endpoint in Credential Service [DEV-3097] #331

Merged
merged 66 commits into from
Aug 18, 2023

Conversation

abdulla-ashurov
Copy link
Contributor

@abdulla-ashurov abdulla-ashurov commented Aug 11, 2023

  • Change DID endpoint from did/:did to did/search/:did.
  • Update swagger OpenAPI.
  • Support query and fragment options for did/search/:did endpoint.
  • Add new GET resource endpoints [MY PROPOSAL]:
    • /resource/search/:did/:resourceId - for getting the specific resource.

@abdulla-ashurov abdulla-ashurov added the enhancement New feature or request label Aug 11, 2023
@abdulla-ashurov abdulla-ashurov self-assigned this Aug 11, 2023
@abdulla-ashurov abdulla-ashurov marked this pull request as ready for review August 11, 2023 08:51
@abdulla-ashurov abdulla-ashurov changed the title feat: Change from did/:did to did/resolve/:didUrl endpoint and support query parameters for DID endpoint in Credential Service [DEV-3097] feat: Change from did/:did to did/search/:didUrl endpoint and support query parameters for DID endpoint in Credential Service [DEV-3097] Aug 11, 2023
Copy link
Contributor

@lampkin-diet lampkin-diet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's fix small issues!

src/middleware/auth/did-auth.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/middleware/auth/did-auth.ts Outdated Show resolved Hide resolved
src/services/identity/IIdentity.ts Outdated Show resolved Hide resolved
src/services/identity/agent.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swagger editor flags errors in the document formatting.

src/app.ts Outdated Show resolved Hide resolved
src/static/swagger.json Outdated Show resolved Hide resolved
src/static/swagger.json Outdated Show resolved Hide resolved
@abdulla-ashurov
Copy link
Contributor Author

Swagger editor flags errors in the document formatting.

Now swagger is working on swagger.editior ✅

src/services/identity/identity.ts Outdated Show resolved Hide resolved
src/services/identity/identity.ts Outdated Show resolved Hide resolved
src/services/identity/identity.ts Outdated Show resolved Hide resolved
src/services/identity/identity.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications look good.

Approved.

@Eengineer1 Eengineer1 merged commit 4e34b76 into develop Aug 18, 2023
@Eengineer1 Eengineer1 deleted the DEV-3097-2 branch August 18, 2023 12:20
cheqd-bot bot pushed a commit that referenced this pull request Aug 18, 2023
## [2.9.0-develop.1](2.8.0...2.9.0-develop.1) (2023-08-18)

### Features

* Change from `did/:did` to `did/search/:didUrl` endpoint and support query parameters for DID endpoint in Credential Service [DEV-3097] ([#331](#331)) ([4e34b76](4e34b76))
@cheqd-bot
Copy link

cheqd-bot bot commented Aug 18, 2023

🎉 This PR is included in version 2.9.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Aug 29, 2023
## [2.9.0](2.8.0...2.9.0) (2023-08-29)

### Features

* Added encrypted StatusList APIs + enhanced type safety ([#350](#350)) ([951e2b4](951e2b4))
* Change from `did/:did` to `did/search/:didUrl` endpoint and support query parameters for DID endpoint in Credential Service [DEV-3097] ([#331](#331)) ([4e34b76](4e34b76))

### Bug Fixes

* Credential Service Staging - Resolve issue with page not loading and broken login [DEV-3162] ([#358](#358)) ([419d2ec](419d2ec))
* Fix problem with agent initialize [DEV-3146] ([#346](#346)) ([45e1074](45e1074))
* Validate did access on operation ([#351](#351)) ([8bbfce1](8bbfce1))
@cheqd-bot
Copy link

cheqd-bot bot commented Aug 29, 2023

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants