-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce dependency resolution (experimental) #891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cefc85
to
68f52e4
Compare
Dom, are resources from dependent profiles not working for now in parent profile? I tried adding:
to |
This commit is the foundation of the dependency resolution as described in #888 . It currently only works with local dependencies, as seen in the example inheritance profile. Tests and full resolution are coming next on the path to an MVP implementation.
fixes #533 |
d3a4eb9
to
1f8fc3a
Compare
Signed-off-by: Steven Danna <[email protected]>
Signed-off-by: Steven Danna <[email protected]>
1f8fc3a
to
9957138
Compare
Signed-off-by: Steven Danna <[email protected]>
@alexpop we will address that in further PRs. Great work @arlimus and @stevendanna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the foundation of the dependency resolution as described in #888 .
It currently only works with local dependencies, as seen in the example inheritance profile.
Tests and full resolution are coming next on the path to an MVP implementation.