Generate test labels for multi-test controls #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # If it's an anonymous control, just go with the only description | ||
| # available for the underlying test. | ||
| summary = c[:code_desc].to_s unless summary | ||
| summary + c[:message].to_s |
There was a problem hiding this comment.
Should we add a space in front of the message here?
chris-rock
changed the title
| elsif res.length == 0 | ||
| # Empty control block - if it's anonymous, there's nothing we can do. | ||
| # Is this case even possible? | ||
| summary = "Empty anonymous control" unless summary |
There was a problem hiding this comment.
I think you want something like: summary || "Empty anonymous control" otherwise this will return nil in the case that summary is already defined.
ksubrama
force-pushed
the
ksubrama/json_fix
branch
from
32145a9 to
f30778a
Compare
|
@ssd I refactored it in a slightly different way but I think I hit all the issues you pointed out. |
|
@ksubrama Nice refactor! |
ksubrama
changed the title
|
Also fixes: #872 |
|
👍 from me |
|
Great work @ksubrama |
chris-rock
force-pushed
the
ksubrama/json_fix
branch
from
f30778a to
e35dd33
Compare
|
|
ksubrama
force-pushed
the
ksubrama/json_fix
branch
from
e35dd33 to
0f572df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #812
Fix #872