Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename --key-file to --key on cli #60

Merged
merged 2 commits into from
Oct 2, 2015
Merged

rename --key-file to --key on cli #60

merged 2 commits into from
Oct 2, 2015

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Oct 2, 2015

No description provided.

Signed-off-by: Dominik Richter <[email protected]>
@@ -55,7 +55,7 @@ class VulcanoCLI < Thor
desc: 'The login user for a remote scan.'
option :password, type: :string, default: nil,
desc: 'Login password for a remote scan, if required.'
option :key_file, type: :string, default: nil,
option :key, type: :string, default: nil,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it

@arlimus arlimus force-pushed the cli--key branch 2 times, most recently from 8d922ea to 6dde5dc Compare October 2, 2015 20:35
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@chris-rock
Copy link
Contributor

@delivery approve

chef-delivery added a commit that referenced this pull request Oct 2, 2015
Merged change 2101f59e-fbad-4209-85a3-473a950b084a

From review branch cli--key into master

Signed-off-by: chartmann <[email protected]>
@chef-delivery chef-delivery merged commit ba8f1ec into master Oct 2, 2015
@chef-delivery
Copy link
Contributor

Change: 2101f59e-fbad-4209-85a3-473a950b084a approved by: @chris-rock

@chef-delivery chef-delivery deleted the cli--key branch October 2, 2015 21:22
@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

clintoncwolfe pushed a commit that referenced this pull request Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants