add shadow resource for /etc/shadow #471
Conversation
|
|
||
| def initialize(path = nil, opts = nil) | ||
| opts ||= {} | ||
| @path = path || '/etc/shadow' |
There was a problem hiding this comment.
nitpicking, but how about
def initialize(path = '/etc/shadow', opts = {})
|
@arlimus: great resource. Went a little bonkers with non-important code style comments ;) LGTM 👍 |
| @@ -0,0 +1,130 @@ | |||
| # encoding: utf-8 | |||
| # copyright: 2015, Chef Software Inc. | |||
arlimus
force-pushed
the
dr/shadow
branch
2 times, most recently
from
f5f187c to
2ee967e
Compare
|
|
||
| def initialize(path = '/etc/shadow', opts = nil) | ||
| opts ||= {} | ||
| @path = path || '/etc/shadow' |
There was a problem hiding this comment.
This is redundant now, isn't it?
@path = path
There was a problem hiding this comment.
Almost: what if shadow(nil). It will not happen intentionally, but may happen by accident. I'm not sure yet how we want to handle this case though. Throwing a ruby fail seems too harsh, maybe improve this in the next iteration. It is true for a lot of resources...
There was a problem hiding this comment.
Ok, another edge case I didn't notice. Thanks.
My original comment then doesn't make too much sense then (i.e. the case against path=nil)...
|
That looks really good. I like to see filter everywhere now. |
|
Thanks @arlimus |
add shadow resource for /etc/shadow
No description provided.