bugfix: windows server 2008 detection #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Richter <[email protected]>
…3, only distinguishes via build number
arlimus
added a commit
that referenced
this pull request
Sep 23, 2015
bugfix: windows server 2008 detection
jquick
pushed a commit
that referenced
this pull request
Feb 6, 2018
Some object methods have been deprecated in v0.11.0 of the arm sdks. This commit fixes the get_resources method by using the new resources object instance method. We are also updating the Gemfile accordingly. Signed-off-by: sanabriad <[email protected]>
jquick
pushed a commit
that referenced
this pull request
Feb 6, 2018
Some object methods have been deprecated in v0.11.0 of the arm sdks. This commit fixes the get_resources method by using the new resources object instance method. We are also updating the Gemfile accordingly. Signed-off-by: sanabriad <[email protected]>
clintoncwolfe
pushed a commit
that referenced
this pull request
Feb 7, 2018
* Add access_keys method to aws_iam_user Signed-off-by: Chris Redekop <[email protected]> * Fix unit test that accessed AWS Signed-off-by: Chris Redekop <[email protected]> * Incorporate PR feedback Signed-off-by: Chris Redekop <[email protected]> * Fix unit tests Signed-off-by: Chris Redekop <[email protected]> * Update tests based on PR feedback Signed-off-by: Chris Redekop <[email protected]> * Rebase to master Signed-off-by: Chris Redekop <[email protected]>
clintoncwolfe
added a commit
that referenced
this pull request
Jul 7, 2023
* Fix systemd path for Leap image
* Use vhef client version 17 as doocker cookbook do not support >= 18
* Add nftables resource
* Add nftables tests
* Add fixtures for nftables tests
* enable nftables only when attr is true - then disable iptables
* By default test iptables, not nftables
* Fix tests and lint errors
* Increase unit test coverage for nftables
* Do not use -nn nft option as behaviour changes based on nft version
* Base nft params identification on its version, not os version
Signed-off-by: Jeremy JACQUE <[email protected]>
* Make test more human friendly by reversing unless/if logic
Signed-off-by: Jeremy JACQUE <[email protected]>
* Update mocked cmds with nft params
Signed-off-by: Jeremy JACQUE <[email protected]>
* Fix quoting issue with rubocop
* Fix uninitiallized class vars
* Fix unit test by adding nft version mocking
* Clean nftables doc
---------
Signed-off-by: Jeremy JACQUE <[email protected]>
Co-authored-by: jjacque <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.