semantics: rename CLI plugins registry -> commands #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-rock not sure if in or out, what do you think? |
| @@ -143,7 +143,7 @@ class Inspec::InspecCLI < Inspec::BaseCLI # rubocop:disable Metrics/ClassLength | |||
| end | |||
|
|
|||
| # load CLI plugins before the Inspec CLI has been started | |||
| Inspec::Plugins::CLI.registry.each { |_subcommand, params| | |||
| Inspec::Plugins::CLI.commands.each { |_subcommand, params| | |||
There was a problem hiding this comment.
maybe we should use subcommands to be very explicit
|
+1 i like it, since this solves some confusion |
|
Thank you for your feedback, I like |
arlimus
force-pushed
the
dr/semantics
branch
2 times, most recently
from
eaacc55 to
9cfc067
Compare
| @@ -18,11 +18,11 @@ | |||
| before do | |||
| # TODO: remove this, once the plugin loading is not based on ruby-load time | |||
| # initialization | |||
| cli_reg.registry.clear | |||
| cli_reg.subcommands.clear | |||
There was a problem hiding this comment.
btw: i don't think these lines go away with ruby-load time initialization (which we changed in #434). e.g. if the second test (which adds subcommand) runs before the first one, the command is still in the registry.
imho: this line must stay in because right now we are dealing with a global singleton registry.
Basically make sure everyone understands these are only subcommands. we might consider adding plugins for options or existing commands instead of new subcommands. this just ensures everyone knows what registry is for
arlimus
added a commit
that referenced
this pull request
Feb 9, 2016
semantics: rename CLI plugins registry -> commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically make sure everyone understands these are only subcommands. we might consider adding plugins for options or existing commands instead of new subcommands. this just ensures everyone knows what registry is for