make metadata.rb legacy mode consistent for supports #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before introducing InSpec profiles in #252 we had `metadata.rb` keep all information. This included an undisclosed field called `supports`. However, this field was never actually used in practice. So for legacy profiles, this means that `supports` was ignored. In order to keep old profiles running in exactly the way they were before, ignore this field when reading from metadata.rb
| @@ -35,14 +35,9 @@ def initialize(ref, logger = nil) | |||
| end | |||
|
|
|||
| def supports(sth, version = nil) | |||
| params[:supports] ||= [] | |||
There was a problem hiding this comment.
we share the same implementation for inspec.yml and metadata.rb. I would assume, this breaks the new feature as well?
There was a problem hiding this comment.
Actually not quite: We load yaml and then only finalize the params. That function is never called :)
Look:
|
This causes an error with compliance profiles, that use the old metadata.rb structure and fill in the field supports. It handles all those targets correctly, where supports specifies the OS by name. However, with setting: it will fail on all systems (unless you find one where OS-name is 'linux' ;) ). This takes care of the issue, by ignoring that field completely, since that syntax is deprecated. |
chris-rock
added a commit
that referenced
this pull request
Jan 15, 2016
make metadata.rb legacy mode consistent for supports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before introducing InSpec profiles in #252 we had
metadata.rbkeep all information. This included an undisclosed field calledsupports. However, this field was never actually used in practice. So for legacy profiles, this means thatsupportswas ignored. In order to keep old profiles running in exactly the way they were before, ignore this field when reading from metadata.rb