-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AIX classes, tests, and targetted ssh testing #333
Conversation
foobarbam
commented
Dec 23, 2015
@foobarbam huge addition. Thank you very much for this great Christmas present. I am going to test this PR as my my first task next week. |
when 'aix' | ||
describe package('bos.rte') do | ||
it { should be_installed } | ||
its('version') { should match /^(6|7)\.1[.|\d]+\d/ } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be its('version') { should match /^(6|7)[.|\d]+\d/ }
. Then it works out of the box with AIX 7.2 beta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Hi @foobarbam thanks again for this great addition. Some questions:
Here are my failure reports:
Please let me know if you need help. |
# } | ||
proc_id = port_id = nil | ||
lsof_cmd.stdout.each_line do |line| | ||
line.chomp! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract the line parser in a separate function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
sorry guys, missed most of these comments due to taking the holidays off. I'll be back next week to address them all. Thanks for the feedback! |
awesome work @foobarbam thanks for adding this great AIX support |
Adding AIX classes, tests, and targetted ssh testing