Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add A2 support for profile compliance depends #3014

Merged
merged 1 commit into from
May 3, 2018
Merged

Add A2 support for profile compliance depends #3014

merged 1 commit into from
May 3, 2018

Conversation

jquick
Copy link
Contributor

@jquick jquick commented May 3, 2018 •
edited
Loading

This change allows A2 compliance services to properly function when defined as a profile dependency.

This allows you to run:

depends:
  - name: ssh-baseline
    compliance: admin/ssh-baseline

in a profile wrapper and work correctly with A2

Signed-off-by: Jared Quick [email protected]

@jquick jquick requested a review from a team as a code owner May 3, 2018 01:58
@jquick jquick added the Type: Bug Feature not working as expected label May 3, 2018
@jquick jquick force-pushed the jq/fix_a2_compliance_depends branch from 54aee71 to dae3ecc Compare May 3, 2018 12:56
@jquick jquick force-pushed the jq/fix_a2_compliance_depends branch from dae3ecc to c794947 Compare May 3, 2018 13:10
@jquick jquick added the Aspect: Integration Plays well with others label May 3, 2018
clintoncwolfe
clintoncwolfe approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, after I read the input structure. Thanks!

@jquick jquick merged commit 54c1ed6 into master May 3, 2018
@jquick jquick deleted the jq/fix_a2_compliance_depends branch May 3, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

Assignees
No one assigned
Labels
Aspect: Integration Plays well with others Type: Bug Feature not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jquick @miah @clintoncwolfe