Split inspec into a core gem. #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miah Johnson <[email protected]>
Signed-off-by: Miah Johnson <[email protected]>
Signed-off-by: Miah Johnson <[email protected]>
Signed-off-by: Jared Quick <[email protected]>
Signed-off-by: Jared Quick <[email protected]>
clintoncwolfe
approved these changes
May 3, 2018
| require 'rake/testtask' | ||
| require 'passgen' | ||
| require 'train' | ||
| require_relative 'tasks/maintainers' | ||
| require_relative 'tasks/spdx' | ||
|
|
||
| Bundler::GemHelper.install_tasks name: 'inspec' |
There was a problem hiding this comment.
Would it make sense to have a Rake task for building the inspec-core gem, as well?
| spec.files = %w{README.md MAINTAINERS.toml MAINTAINERS.md LICENSE | ||
| inspec-core.gemspec Gemfile CHANGELOG.md} + | ||
| Dir.glob('{bin,docs,examples,lib}/**/*', File::FNM_DOTMATCH) | ||
| .reject { |f| File.directory?(f) || f =~ /aws|azure|gcp/ } |
There was a problem hiding this comment.
We should (eventually) make this regex more obvious - possibly make it a variable or env var. This will be a brittle point.
jquick
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
inspec-core.gemspecto allow InSpec to be dependent ontrain-corewhich is distributed without support for additional cloud providers.