Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Habitat plan #3000

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Update Habitat plan #3000

merged 1 commit into from
Apr 27, 2018

Conversation

jerryaldrichiii
Copy link
Contributor

This updates the included Habitat plan to do the following:

  • Include binaries needed for certain resources (Example: curl)
  • Use gem install/build instead of Bundler
  • Use a wrapper binary to ensure GEM_HOME and GEM_PATH are correct
  • Perform build/install steps in a cache directory instead of /src

Many thanks to @miah @tduffield!

This updates the included Habitat plan to do the following:
  - Include binaries needed for certain resources (Example: `curl`)
  - Use `gem install/build` instead of Bundler
  - Use a wrapper binary to ensure GEM_HOME and GEM_PATH are correct
  - Perform build/install steps in a cache directory instead of `/src`

Many thanks to @miah @tduffield

Signed-off-by: Jerry Aldrich <[email protected]>
@jerryaldrichiii jerryaldrichiii requested a review from a team as a code owner April 27, 2018 00:52
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jquick jquick requested a review from tduffield April 27, 2018 12:15
core/less
core/mysql-client
core/netcat
core/postgresql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a full pg server or just the clients?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Habitat doesn't currently have a package that contains only the clients. Could be worth making one though...

Copy link

@vjeffrey vjeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please!

@jquick jquick merged commit 700d042 into master Apr 27, 2018
@jquick jquick deleted the ja/update-habitat-plan branch April 27, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants