Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shadow#to_s to return @path instead of hardcoded /etc/shadow #2978

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Update shadow#to_s to return @path instead of hardcoded /etc/shadow #2978

merged 1 commit into from
Apr 26, 2018

Conversation

miah
Copy link
Contributor

@miah miah commented Apr 19, 2018 •
edited
Loading

The #to_s method should return the @path rather than a hardcoded /etc/shadow.

previously:

inspec> s = shadow('/Users/miah/projects/github/tmp/inspec/test/unit/mock/files/shadow')
=> /etc/shadow

now:

inspec> a = shadow('/Users/miah/projects/github/tmp/inspec/test/unit/mock/files/shadow')
=> /Users/miah/projects/github/tmp/inspec/test/unit/mock/files/shadow

Signed-off-by: Miah Johnson [email protected]

Fixes #2977

@miah miah requested a review from a team as a code owner April 19, 2018 21:31
@miah miah force-pushed the miah/shadow_to_s branch from 4d6d545 to b67878d Compare April 19, 2018 21:32
clintoncwolfe
clintoncwolfe approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miah! I ran unit tests, looks good!

jquick
jquick approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miah !

@jquick jquick added the Type: Enhancement Improves an existing feature label Apr 26, 2018
@jquick jquick merged commit 709647c into master Apr 26, 2018
@jquick jquick deleted the miah/shadow_to_s branch April 26, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@jquick jquick jquick approved these changes

Assignees
No one assigned
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miah @clintoncwolfe @jquick @adamhjk