Add A2 support to the inspec-compliance toolset #2963
Conversation
Signed-off-by: Jared Quick <[email protected]>
jquick
force-pushed
the
jq/compliance_a2_support
branch
from
4de2de9 to
ccf178d
Compare
| @@ -18,12 +19,15 @@ class API | |||
| # return all compliance profiles available for the user | |||
| # the user is either specified in the options hash or by default | |||
| # the username of the account is used that is logged in | |||
| def self.profiles(config) | |||
| def self.profiles(config) # rubocop:disable PerceivedComplexity, Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/MethodLength | |||
There was a problem hiding this comment.
You're getting dinged for these things because it's past time to treat API as an abstract parent class and make concrete subclasses for the differing targets; API_Compliance, API_Automate, and API_Automate2. Almost all of the conditional code you had to expand here goes away.
There was a problem hiding this comment.
Yeah, I really wanted to break up a lot of this code into sub classes like this. I will take a shot at it and see if I can fit in into the timeline.
There was a problem hiding this comment.
Started down this path a bit tonight, its much cleaner but there is a LOT to do here. We call the compliance stuff all over and will need to be re-done with instance classes and caching. I will create a ticket to get this refactor in as its needed but out of scope for now.
There was a problem hiding this comment.
#2964 added, thanks for the feedback.
jquick
force-pushed
the
jq/compliance_a2_support
branch
2 times, most recently
from
040a721 to
9fc0032
Compare
Signed-off-by: Jared Quick <[email protected]>
jquick
force-pushed
the
jq/compliance_a2_support
branch
from
9fc0032 to
8acf148
Compare
|
Confirmed with @vjeffrey that these changes are working as expected. |
This is the initial support for Automate 2 with the compliance tools. This supports login/upload/download/exec/logout calls accordingly.
Signed-off-by: Jared Quick [email protected]