-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline and attached policies for aws_iam_user and aws_iam_users #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintoncwolfe
added
Type: New Feature
Adds new functionality
Platform: AWS
Amazon Web Services-related issues
Aspect: Performance
Nimble is delightful.
labels
Apr 11, 2018
jquick
approved these changes
Apr 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @clintoncwolfe !
docs/resources/aws_iam_users.md.erb
Outdated
|
||
### has\_attached\_policies | ||
|
||
True or false. Filters the users to include only those that have at least one IAM managed policy attached to the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes these lines have 2 spaces after the period and sometimes they have 1. We should uniform it.
…eatures to aws_iam_user Signed-off-by: Clinton Wolfe <[email protected]>
Signed-off-by: Clinton Wolfe <[email protected]>
Signed-off-by: Clinton Wolfe <[email protected]>
…cies Signed-off-by: Clinton Wolfe <[email protected]>
…ed policies. Still need docs. Signed-off-by: Clinton Wolfe <[email protected]>
Signed-off-by: Clinton Wolfe <[email protected]>
Signed-off-by: Clinton Wolfe <[email protected]>
clintoncwolfe
force-pushed
the
cw/aws_iam_users_policies
branch
from
April 17, 2018 16:41
08d7245
to
f1fb5dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Aspect: Performance
Nimble is delightful.
Platform: AWS
Amazon Web Services-related issues
Type: New Feature
Adds new functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds matchers, properties, and filters for auditing policies attached to or embedded in AWS IAM users for both the singular and plural resources.
Also expands documentation on
aws_iam_users
, which had a lot missing.Adds extensive integration tests around users and policies, in anticipation of #2749 being expanded to policies attached or embedded on users.
Among the properties are the ones needed to enable fetching individual policies for policy searching. The policies themselves are not fetched.
This PR will introduce a further performance degradation on
aws_iam_user
and more severely onaws_iam_users
. Tracked on #2370 and #2942 .Fixes #2719