Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline and attached policies for aws_iam_user and aws_iam_users #2947

Merged
merged 8 commits into from
Apr 17, 2018

Conversation

clintoncwolfe
Copy link
Contributor

@clintoncwolfe clintoncwolfe commented Apr 11, 2018

Adds matchers, properties, and filters for auditing policies attached to or embedded in AWS IAM users for both the singular and plural resources.

Also expands documentation on aws_iam_users, which had a lot missing.

Adds extensive integration tests around users and policies, in anticipation of #2749 being expanded to policies attached or embedded on users.

Among the properties are the ones needed to enable fetching individual policies for policy searching. The policies themselves are not fetched.

This PR will introduce a further performance degradation on aws_iam_user and more severely on aws_iam_users. Tracked on #2370 and #2942 .

Fixes #2719

@clintoncwolfe clintoncwolfe requested a review from a team as a code owner April 11, 2018 22:19
@clintoncwolfe clintoncwolfe added Type: New Feature Adds new functionality Platform: AWS Amazon Web Services-related issues Aspect: Performance Nimble is delightful. labels Apr 11, 2018
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @clintoncwolfe !


### has\_attached\_policies

True or false. Filters the users to include only those that have at least one IAM managed policy attached to the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes these lines have 2 spaces after the period and sometimes they have 1. We should uniform it.

@clintoncwolfe clintoncwolfe force-pushed the cw/aws_iam_users_policies branch from 08d7245 to f1fb5dd Compare April 17, 2018 16:41
@clintoncwolfe clintoncwolfe merged commit 73b7b69 into master Apr 17, 2018
@clintoncwolfe clintoncwolfe deleted the cw/aws_iam_users_policies branch April 17, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Performance Nimble is delightful. Platform: AWS Amazon Web Services-related issues Type: New Feature Adds new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants