Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example resource syntax #2904

Merged
merged 7 commits into from
Apr 5, 2018
Merged

Update example resource syntax #2904

merged 7 commits into from
Apr 5, 2018

Conversation

jerryaldrichiii
Copy link
Contributor

This makes the example resource satisfy Rubocop and adds a few other recent changes (e.g. supports)

@jerryaldrichiii jerryaldrichiii requested a review from a team as a code owner March 31, 2018 04:02
@jerryaldrichiii jerryaldrichiii force-pushed the ja/update-example-resource branch from a0231d6 to cabbf3e Compare March 31, 2018 04:52
@jerryaldrichiii jerryaldrichiii force-pushed the ja/update-example-resource branch 2 times, most recently from 7cec740 to 33557a0 Compare April 2, 2018 01:47
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jerryaldrichiii !

@@ -58,7 +58,7 @@
"license" => "Apache-2.0",
"summary" => "Demonstrates the use of InSpec Compliance Profile",
"version" => "1.0.0",
"sha256" => "8eed5154c9fa0174067ab475c0ad4a053f772590d129eb324101fe43ef30794d",
"sha256" => "57709d3a3d5cd06f4179be7e6fbe254c09e3af25ce274e474d52623e34487cc4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why this needs to be regenerated, but how are you figuring out what value to put in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run the test, then copy the one that is generated vs the one I expect. Nothing magical.

@jquick jquick added Aspect: Docs Write the Fine Manual Expeditor: Skip All labels Apr 5, 2018
@jquick jquick changed the title docs: Update example resource Update example resource syntax Apr 5, 2018
@jquick jquick merged commit 4731d95 into master Apr 5, 2018
@jquick jquick deleted the ja/update-example-resource branch April 5, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Docs Write the Fine Manual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants