Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin concurrent-ruby to version 1.0 to fix kitchen-ansible example #2879

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Pin concurrent-ruby to version 1.0 to fix kitchen-ansible example #2879

merged 1 commit into from
Mar 26, 2018

Conversation

visibilityspots
Copy link
Contributor

When I tried to install the dependencies with bundle I bumped into a dependency issue with the concurrent-ruby gem.

By pointing the version to 1.0 instead of 0.9 in the Gemfile the dependencies installed fine using bundle.

$ bundle install --path vendor/bundle
Fetching gem metadata from https://rubygems.org/.......
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "concurrent-ruby":
  In Gemfile:
    concurrent-ruby (~> 0.9)

    inspec was resolved to 2.1.11, which depends on
      train (~> 1.2) was resolved to 1.2.0, which depends on
        azure_mgmt_resources (~> 0.15) was resolved to 0.15.1, which depends on
          ms_rest_azure (~> 0.9.0) was resolved to 0.9.0, which depends on
            concurrent-ruby (~> 1.0)

Bundler could not find compatible versions for gem "test-kitchen":
  In Gemfile:
    kitchen-inspec was resolved to 0.23.1, which depends on
      test-kitchen (~> 1.6)

    kitchen-vagrant was resolved to 1.3.1, which depends on
      test-kitchen (~> 1.4)

@visibilityspots visibilityspots requested a review from a team as a code owner March 26, 2018 09:19
@jquick
Copy link
Contributor

jquick commented Mar 26, 2018

Thanks @visibilityspots ! You mind adding a sign-off to your commit?

git commit -s --amend
git push -f

And thanks for your first contribution!!

@visibilityspots
Copy link
Contributor Author

visibilityspots commented Mar 26, 2018 via email

Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me - and as it's in the examples, it's unlikely we'd break something someone is depending on with AIX or something.

@jquick jquick added the Type: Bug Feature not working as expected label Mar 26, 2018
@jquick jquick changed the title Fix: pointed concurrent-ruby to version 1.0 to fix dependencies Pin concurrent-ruby to version 1.0 to fix kitchen-ansible example Mar 26, 2018
@jquick jquick merged commit 87f1f50 into inspec:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants