Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry_key resource was returning an incorrect value #2871

Merged
merged 4 commits into from
Mar 26, 2018

Conversation

omar-irizarry
Copy link
Contributor

When key value was greater than 2147483647 the registry_key resource was returning an incorrect value failing the test even though the expected value and the actual value in the registry were the same.

when key value was greater than 2147483647

Signed-off-by: Omar Irizarry <[email protected]>
@omar-irizarry omar-irizarry requested a review from a team as a code owner March 23, 2018 03:28
Signed-off-by: Omar Irizarry <[email protected]>
Signed-off-by: Omar Irizarry <[email protected]>
(default) key was returning nil even when a value was present.
Signed-off-by: Omar Irizarry <[email protected]>
@jquick
Copy link
Contributor

jquick commented Mar 26, 2018

Hey @omar-irizarry ! Thanks for your first contribution! Welcome to the family.

This looks great, always enjoy enhancing the windows resources.

@jquick jquick requested a review from jerryaldrichiii March 26, 2018 14:07
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Copy link
Contributor

@jerryaldrichiii jerryaldrichiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great catch on the (default) handling!

@jquick jquick added the Type: Enhancement Improves an existing feature label Mar 26, 2018
@jquick jquick merged commit ef8da47 into inspec:master Mar 26, 2018
@omar-irizarry omar-irizarry deleted the omar-irizarry/fix-regkey-resource branch March 26, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants