Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables resource: Add support for other bin paths #2783

Merged
merged 2 commits into from
Mar 6, 2018

Conversation

jerryaldrichiii
Copy link
Contributor

The location of iptables can vary from OS to OS and it is not guaranteed it will be in the PATH based on how sudo + SSH works. See: #450 (comment)

This adds the most common paths and selects the first one that exists.

This fixes #2777

@jerryaldrichiii jerryaldrichiii requested a review from a team as a code owner March 6, 2018 01:05
@jerryaldrichiii jerryaldrichiii force-pushed the ja/fix-iptables-command branch from c1eab6a to e76597e Compare March 6, 2018 01:12
Thanks @miah for the suggestion

Signed-off-by: Jerry Aldrich <[email protected]>
@jerryaldrichiii jerryaldrichiii force-pushed the ja/fix-iptables-command branch from e76597e to 6271842 Compare March 6, 2018 01:13
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @jerryaldrichiii !

@jquick jquick merged commit e4e9076 into master Mar 6, 2018
@jquick jquick deleted the ja/fix-iptables-command branch March 6, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspec iptable rule tests fail when including the sudo cookbook.
3 participants