Fix aws-iam-users pagination #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROBLEM: aws-iam-users resource only retrieves 100 records due to pagination in the AWS IAM list_users function. FIX: Iterate over all the pages using the AWS pagination variables `marker` and `is_truncated` Signed-off-by: Richard Nixon <[email protected]>
Rubocop: Assignment Branch Condition size for fetch_from_api is too high Rubocop: Space missing after colon Rubocop: Use Kernel#loop with break rather than begin/end/until(or while) Signed-off-by: Richard Nixon <[email protected]>
clintoncwolfe
requested changes
Mar 1, 2018
There was a problem hiding this comment.
This is much simpler than the approach I was going to take (in which list_users may be treated as an iterator). Unfortunately this breaks the unit tests, though the fix is simple. Since list_users is now being called with params, alter lines 106 and 131 of test/unit/resources/aws_iam_users_test.rb to read def list_users(criteria = {})
(Thanks @clintoncwolfe) Signed-off-by: Richard Nixon <[email protected]>
|
Cheers @clintoncwolfe |
clintoncwolfe
approved these changes
Mar 1, 2018
|
Thanks - looks great! I've borrowed your approach and applied it to several other resources. |
|
Sweet... that means I don't have to finish my generic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROBLEM: aws-iam-users resource only retrieves 100 records due to pagination
in the AWS IAM list_users function.
FIX: Iterate over all the pages using the AWS pagination variables
markerand
is_truncatedFixes #2760 and part of #2582 (which concerns additional resources)
Signed-off-by: Richard Nixon [email protected]