Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify Matchers page to speak about Universal matchers #2754

Merged
merged 4 commits into from
Mar 1, 2018

Conversation

clintoncwolfe
Copy link
Contributor

Three small changes to the Matchers website page:

  • Indicate that it refers to "universal" matchers (a term I just made up). Just trying to clarify that you can use these on any resource, while many resources also provide specialized matchers.
  • Linkify the table of contents
  • Add a note that RSpec offers matchers, too, but we don't support them. This probably needs some massaging.

@clintoncwolfe clintoncwolfe requested a review from a team as a code owner February 27, 2018 19:12
@clintoncwolfe clintoncwolfe added the Aspect: Docs Write the Fine Manual label Feb 27, 2018
@kagarmoe kagarmoe force-pushed the cw/doc-matchers-clarification branch from 74611be to 22abfd3 Compare February 27, 2018 22:20
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed--Thanks! I pushed my changes to your branch.

Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clintoncwolfe !

@jquick jquick merged commit 154ab8b into master Mar 1, 2018
@jquick jquick deleted the cw/doc-matchers-clarification branch March 1, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants